feat: add shallow comparison option to ignore nested objects and arrays#48
Open
RafaelHubGit wants to merge 1 commit intoAsyncBanana:masterfrom
Open
feat: add shallow comparison option to ignore nested objects and arrays#48RafaelHubGit wants to merge 1 commit intoAsyncBanana:masterfrom
RafaelHubGit wants to merge 1 commit intoAsyncBanana:masterfrom
Conversation
Add new 'shallow' option to diff function that performs shallow comparison by only comparing primitive values at the first level and ignoring nested objects and arrays. This is useful when you only need to track changes in top-level primitive properties without recursing into complex structures. Changes: - Add 'shallow' boolean option to Options interface - Skip objects/arrays in REMOVE, CHANGE, and CREATE operations when shallow mode is enabled - Update test data with simplified car examples instead of provider data - Add comprehensive tests for shallow vs deep comparison modes
Owner
|
I am not entirely comfortable with the correctness sacrifices that need to be made for this change. If there is a clear use case that requires a level of performance that can only be achieved with shallow comparison while still needing the comparison capabilities offered by microdiff (rather than just a loop), I will reconsider. For now, I am putting this on ice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new 'shallow' option to diff function that performs shallow comparison by only comparing primitive values at the first level and ignoring nested objects and arrays. This is useful when you only need to track changes in top-level primitive properties without recursing into complex structures.
Changes: